8000 MNT remove .github/workflows/sync_pull_request.yml by ogrisel · Pull Request #18951 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT remove .github/workflows/sync_pull_request.yml #18951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2020
Merged

MNT remove .github/workflows/sync_pull_request.yml #18951

merged 1 commit into from
Dec 2, 2020

Conversation

ogrisel
Copy link
Member
@ogrisel ogrisel commented Dec 1, 2020

Apparently the sync_pull_request.yml github actions workflow does not work as expected, even for PRs started after the merge of #18695, see for instance #18950 which fails with the following error message:

[...]
Merge made by the 'recursive' strategy.
 .github/workflows/wheels.yml                       |  2 +
 examples/model_selection/plot_grid_search_stats.py | 48 +++++++++++-----------
+ git push pr_remote HEAD:test-sync-workflow
 2 files changed, 26 insertions(+), 24 deletions(-)
To https://github.com/ogrisel/scikit-learn
 ! [remote rejected]     HEAD -> test-sync-workflow (refusing to allow a GitHub App to create or update workflow `.github/workflows/wheels.yml` without `workflows` permission)
error: failed to push some refs to 'https://github.com/ogrisel/scikit-learn'
Error: Process completed with exit code 1.

I don't see how to fix it unfortunately. It seems like a fundamental limitation.

Shall we abandon and remove this workflow?

@ogrisel
Copy link
Member Author
ogrisel commented Dec 1, 2020 •
edited
Loading

Note: @cmarmo also tried it on her recent PR: #18930 (comment) and it did not fail but instead reported that was nothing to do while the last merged with master was pushed 13 hours earlier and there was new commits pushed to master in the mean time... see: #18930 (commits)

@ogrisel
Copy link
Member Author
ogrisel commented Dec 1, 2020

ping @thomasjpfan @adrinjalali .

thomasjpfan
thomasjpfan approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets remove this for now.

@NicolasHug
Copy link
Member

Just curious: what was this workflow doing?

@thomasjpfan
Copy link
Member

It was suppose to allow a reviewer to add a "ci sync" label to a PR which would sync the PR with master. (If there are not merge conflicts)

@thomasjpfan
Copy link
Member

I tested this in my fork and everything seemed to work, but for some reason it doesn't work on the main repo.

@cmarmo
Copy link
Contributor
cmarmo commented Dec 2, 2020 •
edited
Loading

@thomasjpfan if you are still motivated for working on it you have a testbed here

@NicolasHug NicolasHug changed the title [RFC] remove .github/workflows/sync_pull_request.yml MNT remove .github/workflows/sync_pull_request.yml Dec 2, 2020
@NicolasHug NicolasHug merged commit e21319f into scikit-learn:master Dec 2, 2020
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
Merged
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@ogrisel @glemaitre
MNT remove .github/workflows/sync_pull_request.yml (scikit-learn#18951)
f83cd72
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@ogrisel @glemaitre
MNT remove .github/workflows/sync_pull_request.yml (#18951)
218b03e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogrisel @NicolasHug @thomasjpfan @cmarmo
0