Restore previous sample_weight validation behaviour in BaseWeightBoosting #18935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that based on the failing tests quite a few things depend on the behaviour currently in place. On further digging, the approach proposed in #15531 (using a config parameter to allow negative weights) is a better and more mature alternative to the changes I have proposed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #18934
What does this implement/fix? Explain your changes.
Described in #18934
Support (or rather don't explicitly disallow) negative sample weights as long as their sum is not negative.
Any other comments?
I opened this PR in case this proposed trivial change is enough (i.e. restoring previous behaviour) to close the above issue.
Thank you all for this library, it's really neat.