8000 Fix DeprecationWarning for np.bool type. by cmarmo · Pull Request #18927 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Fix DeprecationWarning for np.bool type. #18927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2020
Merged

Fix DeprecationWarning for np.bool type. #18927

merged 2 commits into from
Nov 27, 2020

Conversation

cmarmo
Copy link
Contributor
@cmarmo cmarmo commented Nov 27, 2020

What does this implement/fix? Explain your changes.

Change np.bool to np.bool_ to avoid numpy DeprecationWarning in nightly build with last versions of numpy.
See the build.

alfaro96
alfaro96 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member
@alfaro96 alfaro96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cmarmo for your PR!

LGTM besides the following suggestion.

@cmarmo @alfaro96
Update sklearn/ensemble/_hist_gradient_boosting/tests/test_gradient_b…
607ad31 
…oosting.py

Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es>
thomasjpfan
B779 thomasjpfan approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit cdde011 into scikit-learn:master Nov 27, 2020
@cmarmo cmarmo deleted the npbool-deprecationwarning branch December 1, 2020 07:47
@alfaro96 alfaro96 mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@alfaro96 alfaro96 alfaro96 approved these changes

Assignees
No one assigned
Labels
module:ensemble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmarmo @thomasjpfan @alfaro96
0