8000 DOC use pipeline in example using RF, RT, GBDT for feature engineering by glemaitre · Pull Request #18835 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC use pipeline in example using RF, RT, GBDT for feature engineering #18835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 1, 2021
Merged

DOC use pipeline in example using RF, RT, GBDT for feature engineering #18835

merged 5 commits into from
Feb 1, 2021

Conversation

glemaitre
Copy link
Member

Modify the example to use some Pipeline and change it to a notebook style example.

thomasjpfan
thomasjpfan reviewed Nov 19, 2020
View reviewed changes
thomasjpfan
thomasjpfan approved these changes Jan 9, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM.

Side note: this feels like stacking where we use apply instead of predict.

glemaitre and others added 2 commits January 11, 2021 19:12
@glemaitre @thomasjpfan
Apply suggestions from code review
0219f1c 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@glemaitre
apply thomas changes
347da76
8000
Base automatically changed from master to main January 22, 2021 10:53
rth
rth approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clearly a non trivial example and a nice code improvement. Thanks!

@rth rth merged commit 69d6378 into scikit-learn:main Feb 1, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@glemaitre @thomasjpfan
EXA use pipeline in feature engineering example with RF,RT,GBDT (scik…
edf9079 
…it-learn#18835)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre added a commit that referenced this pull request 81DD Apr 28, 2021
@glemaitre @thomasjpfan
EXA use pipeline in feature engineering example with RF,RT,GBDT (#18835)
07508a8 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemaitre @rth @thomasjpfan
0