8000 BUG Fix numpy version for `_take_along_axis` in fixes.py by lucyleeow · Pull Request #18745 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

BUG Fix numpy version for _take_along_axis in fixes.py #18745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

lucyleeow
Copy link
Member
@lucyleeow lucyleeow commented Nov 3, 2020

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Fixes numpy version as take_along_axis was new in numpy 1.15 (NOT >1.14).

Any other comments?

cc @ogrisel @glemaitre

@cmarmo cmarmo added this to the 0.24 milestone Nov 3, 2020
@glemaitre glemaitre merged commit c9543e1 into scikit-learn:master Nov 3, 2020
@glemaitre
Copy link
Member

Thanks @lucyleeow

@lucyleeow lucyleeow deleted the np_take branch November 3, 2020 07:58
@ogrisel
Copy link
Member
ogrisel commented Nov 3, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0