MAINT flake8: move E402 ignore rule to setup.cfg for examples folder #18724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the flake8 E402 ignore rule for the example folder (import lines not at the top of the file) would not be taken into account when you run the flake8 command from the top level folder. In particular this would cause some dev environments such as VS Code to display the lint markers for those import lines.
Using the
per-file-ignoresdirective in the top levelsetup.cfgfile makes this configuration work, wherever the flake8 command is run from.I will merge merge if CI stays green.