DOC minor update to make_classification about flip_y #18720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentzenchr
approved these changes
Nov 1, 2020
Comment on lines
102
to
103
| ``weights`` exceeds 1. Note that the actual class proportions will | ||
| not exactly match `weights` when `flip_y` isn't 0. |
There was a problem hiding this comment.
Suggested change
| ``weights`` exceeds 1. Note that the actual class proportions will | |
| not exactly match `weights` when `flip_y` isn't 0. | |
| ``weights`` exceeds 1. Note that only if ``flip_y=0``, the actual class | |
| proportions will exactly match ``weights``. |
There was a problem hiding this comment.
Honestly I find the original phrasing more natural
There was a problem hiding this comment.
I tried to avoid the double negative - just a suggestion.
|
|
||
| flip_y : float, default=0.01 | ||
| The fraction of samples whose class is assigned randomly. Larger | ||
| values introduce noise in the labels and ma 8000 ke the classification | ||
| task harder. Note that the default setting flip_y > 0 might lead | ||
| to less than n_classes in y in some cases. | ||
| to less than `n_classes` in y in some cases. |
There was a problem hiding this comment.
Suggested change
| to less than `n_classes` in y in some cases. | |
| to less than ``n_classes`` in y in some cases. |
Only because in this file double backticks seem to be used consistently.
|
Thanks for the review @lorentzenchr . I switched to double backticks but we typically don't care about single vs double backticks, so lets not go to far in the nitpicks with that ;) |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #18717 to prevent future confusion