8000 FIX deprecate calibrators_ in _CalibratedClassifier by glemaitre · Pull Request #18714 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX deprecate calibrators_ in _CalibratedClassifier #18714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2020
Merged

FIX deprecate calibrators_ in _CalibratedClassifier #18714

merged 3 commits into from
Nov 1, 2020

Conversation

glemaitre
Copy link
Member
@glemaitre glemaitre commented Oct 30, 2020 •
edited
Loading

closes #18712

Solve the second part of the issue in CalibrateClassifierCV.

@glemaitre
Copy link
Member Author

ping @ogrisel @thomasjpfan

I think that this should suffice

thomasjpfan
thomasjpfan reviewed Oct 30, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface of _CalibratedClassifier is interesting because it relies on private functions for construction.

It is a private class, so this is okay for me. Codewise, this PR LGTM

NicolasHug
NicolasHug approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member
@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you explain how it's related to #18712?

I'm wondering whether we even need a deprecation here considering the class is private. We had similar discussion in #14720

@glemaitre
Copy link
Member Author

Can you explain how it's related to #18712?

An example called an attribute that has been removed and circle ci failed.

@glemaitre
Copy link
Member Author

I'm wondering whether we even need a deprecation here considering the class is private. We had similar discussion in #14720

I'm pasting the comment of @ogrisel: For the part on the calibrators, maybe we could introduce a property with a deprecation warning to provide some backward compat.

ogrisel
ogrisel approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @glemaitre, LGTM.

@ogrisel ogrisel merged commit 9358a94 into scikit-learn:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan left review comments

@ogrisel ogrisel ogrisel approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with CircleCI and documentation
4 participants
@glemaitre @ogrisel @NicolasHug @thomasjpfan
0