DOC Whats new tweaks #18604
Merged
DOC Whats new tweaks #18604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentzenchr
approved these changes
Oct 12, 2020
doc/whats_new/v0.24.rst
Outdated
Comment on lines
166
to
167
| 8000 | `regularization`, which can take the values `None`, `components`, | |
| `transformation` or `both`, in accordance with |
There was a problem hiding this comment.
Suggested change
| `regularization`, which can take the values `None`, `components`, | |
| `transformation` or `both`, in accordance with | |
| `regularization`, which can take the values `None`, `'components'`, | |
| `'transformation'` or `'both'`, in accordance with |
There was a problem hiding this comment.
IMHO backticks + quotes hurt readability. For these I think quotes are enough
| - |Fix| Fixed a bug in | ||
| :class:`ensemble.HistGradientBoostingRegressor` and | ||
| :class:`ensemble.HistGradientBoostingClassifier` which can now accept data | ||
| with `uint8` dtype in `predict`. :pr:`18410` by `Nicolas Hug`_. |
There was a problem hiding this comment.
Suggested change
8000
| with `uint8` dtype in `predict`. :pr:`18410` by `Nicolas Hug`_. | |
| with `uint8` dtype in ``predict``. :pr:`18410` by `Nicolas Hug`_. |
| :class:`ensemble.GradientBoostingRegressor` and returns `1`. | ||
| :pr:`17702` by :user:`Simona Maggio <simonamaggio>`. | ||
|
|
||
| - |API|: Mean absolute error ('mae') is now deprecated for the parameter | ||
| - |API| Mean absolute error ('mae') is now deprecated for the parameter |
There was a problem hiding this comment.
Suggested change
| - |API| Mean absolute error ('mae') is now deprecated for the parameter | |
| - |API| Mean absolute error (`'mae'`) is now deprecated for the parameter |
|
The failing CI seems completely unrelated to this PR. |
NicolasHug
approved these changes
Oct 12, 2020
doc/whats_new/v0.24.rst
Outdated
Comment on lines
166
to
167
| `regularization`, which can take the values `None`, `components`, | ||
| `transformation` or `both`, in accordance with |
There was a problem hiding this comment.
IMHO backticks + quotes hurt readability. For these I think quotes are enough
I was looking through the change log and fixing things up as I went, not specifically towards release. But yes, I think we should be homing in on that: release highlights, etc. As you can probably tell, my time has been pretty limited lately. |
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
<
8000
div class="Details-content--hidden mt-2">
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Oct 13, 2020
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
amrcode
pushed a commit
to amrcode/scikit-learn
that referenced
this pull request
Oct 19, 2020
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting entries in consistent order, and relabelling HalvingSearch as a major feature