8000 DOC fix multiclass AUC formulas in user guide by RamyaNP · Pull Request #18559 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC fix multiclass AUC formulas in user guide #18559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2020
Merged

DOC fix multiclass AUC formulas in user guide #18559

merged 1 commit into from
Dec 16, 2020

Conversation

RamyaNP
Copy link
Contributor
@RamyaNP RamyaNP commented Oct 7, 2020

Reference Issues/PRs

Fixes #18515

What does this implement/fix? Explain your changes.

fixes the typos mentioned by the issue

Any other comments?

I am new to contributing for open source. Please bear with me if I've made any silly mistakes

thomasjpfan
thomasjpfan approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @RamyaNP !

doc/modules/model_evaluation.rst
@@ -1382,7 +1382,7 @@ uniformly:

.. math::

\frac{2}{c(c-1)}\sum_{j=1}^{c}\sum_{k > j}^c (\text{AUC}(j | k) +
\frac{1}{c(c-1)}\sum_{j=1}^{c}\sum_{k > j}^c (\text{AUC}(j | k) +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: This 2 should have been canceled out with the 2 used to average the two AUCs.

@reshamas
Copy link
Member

@cmarmo
Can we assign another review to this PR?

@cmarmo
Copy link
Contributor
cmarmo commented Dec 16, 2020

Can we assign another review to this PR?

Perhaps @glemaitre might have a look at this one? Thanks!

@glemaitre glemaitre changed the title Fixed typos in 2 formulae in the AUC macro documentation model_evalution DOC fix multiclass AUC formulas in user guide Dec 16, 2020
@glemaitre glemaitre merged commit d304331 into scikit-learn:master Dec 16, 2020
glemaitre
glemaitre approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre
Copy link
Member

Thanks @RamyaNP

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
@RamyaNP @glemaitre
DOC fix multiclass AUC formulas in user guide (scikit-learn#18559)
7139ae1
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
Merged
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@RamyaNP @glemaitre
DOC fix multiclass AUC formulas in user guide (scikit-learn#18559)
db19d77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo in AUC macro documentation model_evalution
5 participants
@RamyaNP @reshamas @cmarmo @glemaitre @thomasjpfan
0