8000 DOC Add See Also to plotting and metrics by albertvillanova · Pull Request #18314 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Add See Also to plotting and metrics #18314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 3, 2020

Conversation

albertvillanova
Copy link
Contributor

Add "See Also" section to plotting functions, display classes and their metrics.

Close #18308.

@albertvillanova albertvillanova changed the title Add See Also to plotting and metrics DOC Add See Also to plotting and metrics Aug 31, 2020
@@ -750,14 +751,12 @@ def precision_recall_curve(y_true, probas_pred, *, pos_label=None,

See also
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See also
See Also

@glemaitre glemaitre self-requested a review September 1, 2020 08:23
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the display for the plot_partial_dependence in sklearn/inspection/_plot/partial_dependence.py

@glemaitre
Copy link
Member

Otherwise, the rendering is good.

@albertvillanova
Copy link
Contributor Author

@glemaitre, thanks for your review.

@glemaitre glemaitre merged commit 9b1f746 into scikit-learn:master Sep 3, 2020
@glemaitre
Copy link
Member

Thanks @albertvillanova

jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "see also" to plotting functions
2 participants
0