8000 [MRG] FIX len() of ParameterSampler by NicolasHug · Pull Request #18222 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] FIX len() of ParameterSampler #18222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2020
Merged

[MRG] FIX len() of ParameterSampler #18222

merged 2 commits into from
Aug 21, 2020

Conversation

NicolasHug
Copy link
Member

When the param grid is given as all lists in RandomizedSearchCV, we fall back to a GridSearch-like behaviour. The __len__ magic was incorrect in this case when we ask for more candidates than what's actually possible.

@NicolasHug NicolasHug mentioned this pull request Aug 21, 2020
Open
glemaitre
glemaitre approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amueller
amueller approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member
@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Does this fix all of #18057 though?

< 8000 /div>
@NicolasHug
Copy link
Member Author

No it doesn't fix #18057

@amueller amueller merged commit 28c1ed4 into scikit-learn:master Aug 21, 2020
@NicolasHug
Copy link
Member Author

thanks for the quick reviews!

jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@NicolasHug @jayzed82
[MRG] FIX len() of ParameterSampler (scikit-learn#18222)
84c4c04 
* fix len

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:model_selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @amueller @glemaitre
0