10000 DOC Fix doc of defaults in sklearn.utils.validation.py by franslarsson · Pull Request #18048 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Fix doc of defaults in sklearn.utils.validation.py #18048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2020

Conversation

franslarsson
Copy link
Contributor

Reference Issues/PRs

See #15761

What does this implement/fix? Explain your changes.

This PR change how default values are documented in sklearn.utils.validation.py and update docstring according to guideline.

Any other comments?

Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from those changes LGTM

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@franslarsson
Copy link
Contributor Author

Apart from those changes LGTM

Thanks, I have committed the changes.

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 6a29e2c into scikit-learn:master Aug 1, 2020
@franslarsson franslarsson deleted the doc_utils_validation branch August 4, 2020 19:51
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
…18048)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0