8000 FIX inconsistent hyperparameter and bounds issue in GP kernels by marenwestermann · Pull Request #17946 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX inconsistent hyperparameter and bounds issue in GP kernels #17946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2020
Merged

FIX inconsistent hyperparameter and bounds issue in GP kernels #17946

merged 1 commit into from
Jul 18, 2020
+15 −2

Conversation

marenwestermann
Copy link
Member
@marenwestermann marenwestermann commented Jul 17, 2020 •
edited
Loading

Reference Issues/PRs

Fixes #17943

What does this implement/fix? Explain your changes.

The issue is in _check_bounds_params when one or more hyperparameters are fixed, in which case there will be more hyperparameters than bounds.

The test is also fixed to avoid the warning introduced in that method.

Any other comments?

ping @adrinjalali

@adrinjalali
Copy link
Member
adrinjalali commented Jul 17, 2020 •
edited
Loading

Please add an entry to the change log at doc/whats_new/v*.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.

@adrinjalali
Copy link
Member

could you also make sure the other examples also don't raise the warning?

rth
rth approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member
@rth rth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the GP code but this looks reasonable. Thanks @marenwestermann !

I don't think we need a what's new entry as this only handles an edge case from #12673 merged today.

Let's fix master first, we can deal with warnings at any point there is no rush.

adrinjalali
adrinjalali approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It'd be nice if you could still check the other examples for warnings and send another PR if you find any issues there @marenwestermann

@adrinjalali adrinjalali merged commit 0550793 into scikit-learn:master Jul 18, 2020
@marenwestermann
Copy link
Member Author

I don't think we need a what's new entry as this only handles an edge case from #12673 merged today.

Ok. Then I would like to credit @adrinjalali here for this PR as I cannot claim to have done this by myself.

I'll check the other examples for warnings.

@marenwestermann marenwestermann deleted the ci-fail branch July 20, 2020 08:45
@marenwestermann marenwestermann mentioned this pull request Jul 28, 2020
Merged
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@marenwestermann @jayzed82
FIX inconsistent hyperparameter and bounds issue in GP kernels (sciki…
a5030ef 
…t-learn#17946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:gaussian_process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation CI failing
3 participants
@marenwestermann @adrinjalali @rth
0