[MRG] Relax init parameter checks and add explanatory error messages #17936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5aeae49 to
dfa6bac
Compare
a9d929f to
1639a4e
Compare
We now allow any "type" (uninitialized classes) and all numeric numpy types. See scikit-learn#17756 for a discussion.
This can make it much easier to work with this test while making a pre-existing estimator compatible.
1639a4e to
1e7abee
Compare
7 tasks
rth
reviewed
Jul 20, 2020
There was a problem hiding this comment.
Thanks @timokau ! Generally looks good, however could you please add a test to sklearn/utils/tests/test_estimator_checks.py that check that,
- on a very simple estimator similar to the example in your issue, that
check_parameters_default_constructiblenow passes - on a simple estimator that would take as input some instance of a class, this estimator would fail.
7905839 to
659bea4
Compare
659bea4 to
8c6c313
Compare
|
I didn't think the tests had their own tests 😄 Done. Please have another look. |
thomasjpfan
approved these changes
Aug 7, 2020
rth
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #17756.
What does this implement/fix? Explain your changes.
See #17756. The init parameter checks were unnecessarily restrictive to achieve the goal of checking for immutability. The error messages were also not very helpful when debugging failures, since they simply pointed to failed asserts without explaining which parameter is responsible or why it should have one of the whitelisted types.