FIX remove pytest warning in dataset/tests/test_common.py 8000 #17828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmarmo
reviewed
Jul 5, 2020
| @@ -94,7 +94,8 @@ def _generate_func_supporting_param(param, dataset_type=("load", "fetch")): | |||
| condition=name.startswith("fetch") and _has_network(), | |||
| reason="Skip because fetcher requires internet network", | |||
| )] | |||
| marks.append(markers_fetch.get(name, pytest.mark.basic)) | |||
| if name in markers_fetch: | |||
| marks.append(markers_fetch[name]) | |||
There was a problem hiding this comment.
@glemaitre maybe I'm misunderstanding the link you provided, but shouldn't the pytest.mark.network be added here? The network marker is defined in conftest.py.
There was a problem hiding this comment.
The network is the line just above. But we are going to refactor this part with #17553
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…rn#17828) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the PytestWarning in
test_common.pyfrom dataset