8000 MNT Prevent coverage status update on each upload to codecov by alfaro96 · Pull Request #17822 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Prevent coverage status update on each upload to codecov #17822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2020
Merged

MNT Prevent coverage status update on each upload to codecov #17822

merged 3 commits into from
Jul 4, 2020

Conversation

alfaro96
Copy link
Member
@alfaro96 alfaro96 commented Jul 3, 2020

Reference Issues/PRs

#17818 (comment)

What does this implement/fix? Explain your changes.

This PR prevents that codecov status information is sent on each upload, but after a specific number of CI instances have finished.

Any other comments?

CC @thomasjpfan

@alfaro96
Copy link
Member Author
alfaro96 commented Jul 3, 2020 •
edited
Loading

@thomasjpfan I am +1 about the simpleness of this solution, but -1 about need to hardcode the number of jobs that should upload coverage reports to notify the status.

Feel free to trigger a build for checking that this solution is working!

rth
rth approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable. It's unlikely our CI will get much less jobs at least in the near future. Also it's probably not worth designing a more complex solution for this.

thomasjpfan
thomasjpfan approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this simple solution. Thank you for the PR @alfaro96 !

@thomasjpfan thomasjpfan changed the title MNT (Prototype 1) Prevent coverage status notification on each upload to codecov MNT Prevent coverage status update on each upload to codecov Jul 4, 2020
@thomasjpfan thomasjpfan merged commit 3cd62b3 into scikit-learn:master Jul 4, 2020
@alfaro96 alfaro96 deleted the send_all_codecov_information branch July 5, 2020 09:16
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
@alfaro96 @glemaitre
MNT Prevent coverage status update on each upload to codecov (scikit-…
f23acf4 
…learn#17822)
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 @jayzed82
MNT Prevent coverage status update on each upload to codecov (scikit-…
bf72c21 
…learn#17822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfaro96 @rth @thomasjpfan
0