ENH add interpolation parameter to DummyRegressor for "median" and "quantile" strategies #17775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bb6ebb to
4c3e14f
Compare
|
I would not extent DummyRegressor in that direction. Therefore closing. |
|
What is your fix for the GBDT issue? |
|
What needs to be fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires merging #17768
This PR provides the following:
interpolationparameter which can be used with themedianandquantilestrategies;interpolationwhen passing or notsample_weight."linear"will be the default.This PR is useful for creating the original estimator in the GBRT where we want the same interpolation with and without
sample_weightmeaning that we want to set it.