8000 MRG: Deprecate normalize in least_angle models by maikia · Pull Request #17769 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MRG: Deprecate normalize in least_angle models #17769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 18, 2021
Merged

MRG: Deprecate normalize in least_angle models #17769

merged 12 commits into from
Jun 18, 2021

Conversation

maikia
Copy link
Contributor
@maikia maikia commented Jun 29, 2020

Towards: #3020

It deprecates 'normalize' in _least_angle.py:
Lars, LassoLars, LarsCV, LassoLarsCV, LassoLarsIC

@maikia maikia mentioned this pull request Jul 1, 2020
Merged
Base automatically changed from master to main January 22, 2021 10:52
lorentzenchr
lorentzenchr approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A loooooooooooooooooooooooooooong deprecation cycle. Let's get it over with.

LGTM after a changelog entry and CI passes.

sklearn/linear_model/tests/test_least_angle.py Outdated
Comment on lines 144 to 145
# FIXME: 'normalize' to be removed in 1.4
@pytest.mark.filterwarnings("ignore:The default of 'normalize'")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would prefer to set pytestmark = pytest.mark.filterwarnings(...) at the beginning of the test module instead of setting the decorator on every test function.

@agramfort agramfort changed the title WIP: Deprecate normalize in least_angle models MRG: Deprecate normalize in least_angle models Jun 18, 2021
agramfort
agramfort approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member
@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be good to go @rth @lorentzenchr @ogrisel

rth
rth approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member
@rth rth left a comment
A685

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agramfort @maikia !

@rth rth merged commit 8a63ec4 into scikit-learn:main Jun 18, 2021
@lorentzenchr lorentzenchr mentioned this pull request Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

@rth rth rth approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maikia @agramfort @rth @lorentzenchr
0