8000 DEP Deprecates 'normalize' in _bayes.py by maikia · Pull Request #17746 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DEP Deprecates 'normalize' in _bayes.py #17746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Apr 27, 2021
Merged

DEP Deprecates 'normalize' in _bayes.py #17746

merged 22 commits into from
Apr 27, 2021

Conversation

maikia
Copy link
Contributor
@maikia maikia commented Jun 26, 2020

Towards: #3020

It deprecates 'normalize' in _bayes.py:
BayesianRidge
ARDRegression

@maikia maikia mentioned this pull request Jul 1, 2020
Merged
Base automatically changed from master to main January 22, 2021 10:52
@maikia maikia changed the title WIP: Deprecates 'normalize' in _bayes.py Deprecates 'normalize' in _bayes.py Apr 26, 2021
@maikia
Copy link
Contributor Author
maikia commented Apr 26, 2021

@agramfort @ogrisel turn to deprecate normalize in Bayes?

agramfort
agramfort approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member
@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogrisel @lorentzenchr @glemaitre merge if happy

thx @maikia !

lorentzenchr
lorentzenchr approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @maikia Thank you very much for working in the tedious normalize deprecation.

I think the whats_new entry could be nicer, but I would leave that to other (pre-release) PRs.

@lorentzenchr lorentzenchr changed the title Deprecates 'normalize' in _bayes.py DEP Deprecates 'normalize' in _bayes.py Apr 27, 2021
@lorentzenchr lorentzenchr merged commit a45c0c9 into scikit-learn:main Apr 27, 2021
@lorentzenchr lorentzenchr mentioned this pull request Jun 18, 2021
Closed
@NicolasGensollen NicolasGensollen mentioned this pull request Nov 5, 2021
Merged
@eddiebergman eddiebergman mentioned this pull request Nov 15, 2022
Closed
54 tasks
eddiebergman added a commit to automl/auto-sklearn that referenced this pull request Nov 15, 2022
@eddiebergman
chore(ARDRegression): scikit-learn/scikit-learn#17746
b572463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maikia @agramfort @lorentzenchr
0