8000 WIP: Deprecate 'normalize' in Linear Models by maikia · Pull Request #17720 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

WIP: Deprecate 'normalize' in Linear Models #17720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 24 commits into from
Closed

WIP: Deprecate 'normalize' in Linear Models #17720

wants to merge 24 commits into from

Conversation

maikia
Copy link
Contributor
@maikia maikia commented Jun 25, 2020 •
edited
Loading

closes #3020

Currently there are 22 Linear Models which use parameter 'normalize' and 'fit_intercept':

  1. Lasso
  2. LassoLars
  3. Lars
  4. LinearRegression
  5. BayesianRidge
  6. ARDRegression
  7. OrthogonalMatchingPursuit
  8. LassoLarsIC
  9. ElasticNet
  10. Ridge
  11. MultiTaskElasticNet
  12. MultiTaskLasso
  13. RidgeClassifier
  14. LassoCV
  15. LarsCV
  16. LassoLarsCV
  17. OrthogonalMatchingPursuitCV
  18. ElasticNetCV
  19. RidgeCV
  20. MultiTaskElasticNetCV
  21. MultiTaskLassoCV
  22. RidgeClassifierCV

However, when 'fit_intercept' is set to False 'normalize' is not considered.
This PR deprecates 'normalize' in all of the above models (as decided in issue #3020)

@maikia maikia changed the title WIP: Depreciate normalize in Linear Models WIP: Depreciate 'normalize' in Linear Models Jun 25, 2020
@maikia maikia changed the title WIP: Depreciate 'normalize' in Linear Models WIP: Deprecate 'normalize' in Linear Models Jun 25, 2020
maikia added 21 commits June 25, 2020 17:02
@maikia
adding deprecation to _coordinate_descent
c358259
@maikia
added deprecate to _coordinate_descent (tests passing)
d9cb349
@maikia
removed parameter "normalize" from one of the tests as it was alredy …
3a0af4b 
…not used anyway
@maikia
added fixme message to test_coordinate_descent
4c35a0e
@maikia
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …
965d019 
…into depreciate_normalize
@maikia
added deprecate to _least_angle (tests passing)
0a8448f
@maikia
cleaning up
bcc0dcc
@maikia
added fixme to test_least_angle
6cdb039
@maikia
deprecated normalize in _base
84f06cd
@maikia
added fixme message to test_base
0294b46
@maikia
clean up
8102b3f
@maikia
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …
34214f0 
…into depreciate_normalize
@maikia
deprecated normalize in _bayes
20e8b80
@maikia
deprecated in omp
ac69921
@maikia
added deprecation to _ridge
b930bd6
@maikia
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …
6a2f461 
…into depreciate_normalize
@maikia
added fixme to tests
de1ac2c
@maikia
cleaning up
6ce4d54
@maikia
cleaning up
a73dbff
@maikia
cleaning up
4df5106
@maikia
clean up
10445d3
@maikia maikia closed this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalize only applies if fit_intercept=True
1 participant
@maikia
0