8000 DOC Specify the meaning of default=None in cluster module by alfaro96 · Pull Request #17533 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Specify the meaning of default=None in cluster module #17533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

DOC Specify the meaning of default=None in cluster module #17533

merged 1 commit into from
Jun 9, 2020

Conversation

alfaro96
Copy link
Member
@alfaro96 alfaro96 commented Jun 8, 2020

Reference Issues/PRs

Partially addresses #17295.

What does this implement/fix? Explain your changes.

This PR specify the meaning of default=None in the sklearn.cluster module. In particular, specify the meaning for p in sklearn.cluster.DBSCAN and eigen_solver in sklearn.cluster.SpectralClustering and sklearn.cluster.spectral_clustering.

Any other comments?

For consistency, the same in eigen_solver in sklearn.manifold.SpectralEmbedding.

@alfaro96 alfaro96 changed the title [DOC] Specify the meaning of default=None in cluster module DOC Specify the meaning of default=None in cluster module Jun 8, 2020
rth
rth approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alfaro96 !

@rth rth merged commit aad08a6 into scikit-learn:master Jun 9, 2020
@alfaro96 alfaro96 deleted the specify_mean_none_cluster branch June 9, 2020 16:34
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@alfaro96 @viclafargue
DOC Specify the meaning of default=None in cluster module (scikit-lea…
5ad71cc 
…rn#17533)
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 @jayzed82
DOC Specify the meaning of default=None in cluster module (scikit-lea…
7393013 
…rn#17533)
@ogrisel ogrisel mentioned this pull request Oct 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
module:cluster module:manifold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfaro96 @rth
0