DOC add examples to SparseCoder and DictionaryLearning #17521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added example for issue reference ##15233 as well since it's the same file. |
|
@agramfort would you be able to review this one? |
ogrisel
reviewed
Jun 8, 2020
There was a problem hiding this comment.
Thanks for the contrib @Mariam-ke. This looks good. A few suggestions for further improvements below:
ogrisel
reviewed
Jun 9, 2020
|
Hi @Mariam-ke , you have linting issues. You can check the 'Details' link to display the log. |
|
Normally I solved the issue with the linter. I will check the rendering before to merge. |
|
Thank you @Mariam-ke |
|
Thanks for your help @glemaitre |
Closed
rubywerman
pushed a commit
to MLH-Fellowship/scikit-learn
that referenced
this pull request
Jun 24, 2020
…17521) Co-authored-by: Mariam-ke <mariam.haji01@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…17521) Co-authored-by: Mariam-ke <mariam.haji01@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…17521) Co-authored-by: Mariam-ke <mariam.haji01@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples to class docs
Reference Issues #16907
What does this implement/fix? Explain your changes.
Added dictionary learning examples.
Any other comments?