8000 DOC_standardized formatting for default values in transformer class. by ezebunandu · Pull Request #17505 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC_standardized formatting for default values in transformer class. #17505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2020
Merged

DOC_standardized formatting for default values in transformer class. #17505

merged 2 commits into from
Jun 6, 2020

Conversation

ezebunandu
Copy link
Contributor

[MRG] References Issue #15761

Standardized formatting for default values in the preprocessing.FunctionTransformer class.

cc: @amy12xx

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ezebunandu

The guide recommends using the python basic types (bool).

@ezebunandu
Copy link
Contributor Author

[MRG] References Issue #15761

Standardized formatting for default values in the preprocessing.FunctionTransformer class.

cc: @amy12xx

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @amy12xx and @ezebunandu !

@thomasjpfan thomasjpfan merged commit baf8bed into scikit-learn:master Jun 6, 2020
@ezebunandu ezebunandu deleted the doc_default_values_preprocessing_transformer branch June 6, 2020 21:04
@reshamas
Copy link
Member
reshamas commented Jun 6, 2020

#DataUmbrella sprint

viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
…cikit-learn#17505)

* DOC_standardized formatting for default values in transformer class.

* DOC_use type bool instead of boolean

Co-authored-by: Sam Ezebunandu <samuel.ezebunandu@outlook.com>
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
…cikit-learn#17505)

* DOC_standardized formatting for default values in transformer class.

* DOC_use type bool instead of boolean

Co-authored-by: Sam Ezebunandu <samuel.ezebunandu@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4165
Development

Successfully merging this pull request may close these issues.

3 participants
0