8000 [DOC] remove ref to CodeCov browser extension by emdupre · Pull Request #17501 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[DOC] remove ref to CodeCov browser extension #17501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

emdupre
Copy link
Contributor
@emdupre emdupre commented Jun 6, 2020

The Codecov browser extension has been deprecated, and covered/uncovered lines are now shown directly in the reports.

Reference Issues/PRs

References None.

What does this implement/fix? Explain your changes.

Removes reference to deprecated CodeCov browser extension. This comment may confuse future maintainers / developers re how to view covered / uncovered lines.

Any other comments?

Submitted with @annejeevan for the #DataUmbrella sprint

The Codecov browser extension has been deprecated, and covered/uncovered lines are now shown directly in the reports.
@emdupre emdupre changed the title [DOC] remove ref to browser ext [DOC] remove ref to CodeCov browser extension Jun 6, 2020
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@thomasjpfan thomasjpfan merged commit f110672 into scikit-learn:master Jun 6, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
The Codecov browser extension has been deprecated, and covered/uncovered lines are now shown directly in the reports.
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
The Codecov browser extension has been deprecated, and covered/uncovered lines are now shown directly in the reports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0