10000 DOC adding suggested spaces in multioutput/RegressorChain by marenwestermann · Pull Request #17498 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC adding suggested spaces in multioutput/RegressorChain #17498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2020
Merged

DOC adding suggested spaces in multioutput/RegressorChain #17498

merged 3 commits into from
Jun 6, 2020

Conversation

marenwestermann
Copy link
Member

Reference Issues/PRs

References #15215
Towards #3846

What does this implement/fix? Explain your changes.

Adds suggested spaces by reviewer

Any other comments?

cc: (pair programming partner) @LeandroLuque

amueller
amueller approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member
@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

thomasjpfan
thomasjpfan approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan
Copy link
Member

Thank you @marenwestermann and @LeandroLuque!

@thomasjpfan thomasjpfan merged commit 5a85627 into scikit-learn:master Jun 6, 2020
@reshamas
Copy link
Member
reshamas commented Jun 6, 2020

#DataUmbrella sprint

@marenwestermann marenwestermann deleted the regressor-chain branch June 12, 2020 12:55
@cmarmo cmarmo mentioned this pull request Jun 17, 2020
Closed
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@marenwestermann @timnon @viclafargue
DOC adding suggested spaces in multioutput/RegressorChain (scikit-lea…
c5176fb 
…rn#17498)

* example for multioutput regressor

* add spaces (suggested changes) #DataUmbrella

Co-authored-by: Tim Nonner <tim.nonner@tamedia.ch>
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@marenwestermann @timnon @jayzed82
DOC adding suggested spaces in multioutput/RegressorChain (scikit-lea…
8551cf2 
…rn#17498)

* example for multioutput regressor

* add spaces (suggested changes) #DataUmbrella

Co-authored-by: Tim Nonner <tim.nonner@tamedia.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marenwestermann @thomasjpfan @reshamas @amueller @timnon
0