DOC Update default values CalibratedClassifierCV docstring #17494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Jun 6, 2020
sklearn/preprocessing/_data.py
Outdated
| @@ -1754,6 +1754,18 @@ def normalize(X, norm='l2', *, axis=1, copy=True, return_norm=False): | |||
| An array of norms along given axis for X. | |||
| When X is sparse, a NotImplementedError will be raised | |||
| for norm 'l1' or 'l2'. | |||
|
|
|||
| Warning:: Risk of data leak | |||
There was a problem hiding this comment.
Thanks for the PR! This is an unrelated change and shouldn't be in this PR, I think :)
There was a problem hiding this comment.
Thanks, I updated it to contain only the relevant commit.
Updated defalt values of parameters in CalibratedClassifierCV
115e4b3 to
fdae0d4
Compare
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
approved these changes
Jun 7, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…arn#17494) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…arn#17494) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated default values of parameters in CalibratedClassifierCV
Reference Issues/PRs
#15761
Addresses sklearn.calibration.CalibratedClassifierCV
cc NeilBotelho
#DataUmbrella