DOC Add examples to PrecisionRecall and ConfusionMatrix Display #17492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @thomasjpfan |
thomasjpfan
reviewed
Jun 6, 2020
|
|
||
| Examples | ||
| -------- | ||
| >>> import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Some of our CI do not have matplotlib installed.
Suggested change
| >>> import matplotlib.pyplot as plt |
| >>> cm = confusion_matrix(y_test, predictions, labels=clf.classes_) | ||
| >>> disp = ConfusionMatrixDisplay(confusion_matrix=cm, | ||
| >>> display_labels=clf.classes_) | ||
| >>> disp.plot() |
There was a problem hiding this comment.
Suggested change
| >>> disp.plot() | |
| >>> disp.plot() # doctest: +SKIP |
|
|
||
| Examples | ||
| -------- | ||
| >>> import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Suggested change
| >>> import matplotlib.pyplot as plt |
Comment on lines
60
to
61
| >>> viz = PrecisionRecallDisplay(precision=precision, recall=recall) | ||
| >>> viz.plot() |
There was a problem hiding this comment.
Suggested change
| >>> viz = PrecisionRecallDisplay(precision=precision, recall=recall) | |
| >>> viz.plot() | |
| >>> disp = PrecisionRecallDisplay(precision=precision, recall=recall) | |
| >>> disp.plot() # doctest: +SKIP |
…into doc_add_metrics_examples
|
Hey @thomasjpfan , I have made the suggested changes. Can you please take a look at the latest commit? Thanks! |
thomasjpfan
reviewed
Jun 7, 2020
Comment on lines
51
to
53
| >>> X_train, X_test, y_train, y_test = train_test_split(X, | ||
| >>> y, | ||
| >>> random_state=0) |
There was a problem hiding this comment.
Suggested change
| >>> X_train, X_test, y_train, y_test = train_test_split(X, | |
| >>> y, | |
| >>> random_state=0) | |
| >>> X_train, X_test, y_train, y_test = train_test_split(X, y, | |
| ... random_state=0) |
Comment on lines
52
to
54
| >>> X_train, X_test, y_train, y_test = train_test_split(X, | ||
| >>> y, | ||
| >>> random_state=0) |
There was a problem hiding this comment.
Suggested change
| >>> X_train, X_test, y_train, y_test = train_test_split(X, | |
| >>> y, | |
| >>> random_state=0) | |
| >>> X_train, X_test, y_train, y_test = train_test_split(X, y, | |
| ... random_state=0) |
|
Hey @thomasjpfan, I have made the latest suggested changes. Can you please check these? Also, I am not able to understand build failures. Can you please help me understand these? |
thomasjpfan
reviewed
Jun 7, 2020
| >>> from sklearn.svm import SVC | ||
| >>> X, y = make_classification(random_state=0) | ||
| >>> X_train, X_test, y_train, y_test = train_test_split(X, y, | ||
| >>> random_state=0) |
There was a problem hiding this comment.
Suggested change
| >>> random_state=0) | |
| ... random_state=0) |
| >>> predictions = clf.predict(X_test) | ||
| >>> cm = confusion_matrix(y_test, predictions, labels=clf.classes_) | ||
| >>> disp = ConfusionMatrixDisplay(confusion_matrix=cm, | ||
| >>> display_labels=clf.classes_) |
There was a problem hiding this comment.
Suggested change
| >>> display_labels=clf.classes_) | |
| ... display_labels=clf.classes_) |
| >>> from sklearn.svm import SVC | ||
| >>> X, y = make_classification(random_state=0) | ||
| >>> X_train, X_test, y_train, y_test = train_test_split(X, y, | ||
| >>> random_state=0) |
There was a problem hiding this comment.
Suggested change
| >>> random_state=0) | |
| ... random_state=0) |
|
@thomasjpfan Thanks, Verified by running the tests locally. I had to add the return value to |
thomasjpfan
approved these changes
Jun 7, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #3846
What does this implement/fix? Explain your changes.
This PR adds examples to PrecisionRecallDisplay and ConfusionMatrixDisplay classes.
Any other comments?
CC @violetr #dataumbrella