8000 [MRG] Issue #17345: Added keyword arguments to make_pipeline by loldja · Pull Request #17477 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Issue #17345: Added keyword arguments to make_pipeline #17477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2020
Merged

[MRG] Issue #17345: Added keyword arguments to make_pipeline #17477

merged 2 commits into from
Jun 6, 2020

Conversation

loldja
Copy link
Contributor
@loldja loldja commented Jun 6, 2020

#DataUmbrella
Work with: https://github.com/madelgi
cc: @madelgi
Added memory and verbose
Modified call to make_pipeline

Reference Issues/PRs
Issue #17345

What does this implement/fix? Explain your changes.
Adds keyword arguments to make_pipeline function to for Issue #17345

Any other comments?

@amueller
Copy link
Member
amueller commented Jun 6, 2020 •
edited
Loading

Awesome! Looks good, let's wait for CI to run!

thomasjpfan
thomasjpfan approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge when the CI passes.

@thomasjpfan
Copy link
Member

Looks like test_make_pipeline need to be updated with the error message.

@thomasjpfan thomasjpfan merged commit 1019f98 into scikit-learn:master Jun 6, 2020
@thomasjpfan
Copy link
Member

Thank you @loldja and @madelgi!

@alfaro96 alfaro96 mentioned this pull request Jun 16, 2020
Closed
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@loldja @viclafargue
ENH: Added keyword arguments to make_pipeline (scikit-learn#17477)
0cfac1f 
* kwarg make_pipeline

* update tests for make_pipeline

Co-authored-by: Lauren Oldja <laurenoldja@LaurenOldjasMBP.fios-router.home>
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@loldja @jayzed82
ENH: Added keyword arguments to make_pipeline (scikit-learn#17477)
c828f61 
* kwarg make_pipeline

* update tests for make_pipeline

Co-authored-by: Lauren Oldja <laurenoldja@LaurenOldjasMBP.fios-router.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loldja @amueller @thomasjpfan
0