-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG] DOC Fix documentation of default values in cluster module #17455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pgithubs!
I provide some minor comments.
<
8000
/summary>
Thanks for the review @alfaro96 , I've made those changes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when these changes are applied.
Thanks @pgithubs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pgithubs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rn#17455) * updated _affinity_propagation.py docstrings in line with scikit-learn#15761 * updated cluster module docstrings in line with scikit-learn#15761 * updated cluster module docstrings post review scikit-learn#15761 * updated cluster module docstrings post review scikit-learn#15761 Co-authored-by: Greg Knowles <gitgreg123@users.noreply.github.com>
…rn#17455) * updated _affinity_propagation.py docstrings in line with scikit-learn#15761 * updated cluster module docstrings in line with scikit-learn#15761 * updated cluster module docstrings post review scikit-learn#15761 * updated cluster module docstrings post review scikit-learn#15761 Co-authored-by: Greg Knowles <gitgreg123@users.noreply.github.com>
Reference Issues/PRs
Delivers towards #15761
What does this implement/fix? Explain your changes.
Makes changes to docstrings to remove optional and specify default=None. Also some generic docstring updates inline with guidance.
Any other comments?
This only delivers updates to the cluster module