DOC: Add example to linear_model.PoissonRegressor #17453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still WIP or do you want reviews? |
amueller
approved these changes
Jun 6, 2020
thomasjpfan
reviewed
Jun 6, 2020
sklearn/linear_model/_glm/glm.py
Outdated
| >>> clf.fit(X, y) | ||
| PoissonRegressor(alpha=0.95) | ||
| >>> print(clf.coef_) | ||
| [0.30189415 0.30189415] |
There was a problem hiding this comment.
Suggested change
| [0.30189415 0.30189415] | |
| [0.301... 0.301...] |
There was a problem hiding this comment.
Thanks. I applied this format (also other results)
sklearn/linear_model/_glm/glm.py
Outdated
| ---------- | ||
| >>> from sklearn import linear_model | ||
| >>> clf = linear_model.PoissonRegressor(alpha=0.95) | ||
| >>> X = [[0, 0], [1, 1], [2, 2]] |
There was a problem hiding this comment.
Can we have an example where the coef_ are different between the two features?
There was a problem hiding this comment.
Good idea.
I fixed it.
|
Thanks for your review! |
thomasjpfan
reviewed
Jun 7, 2020
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
|
Thanks for your suggestion! Also, I noticed that |
thomasjpfan
approved these changes
Jun 7, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
* [WIP]: Add examples to linear_model.PoissonRegressor * Address review * Address review * Apply suggestions from code review Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Remove numpy import Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
* [WIP]: Add examples to linear_model.PoissonRegressor * Address review * Address review * Apply suggestions from code review Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> * Remove numpy import Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Relates to #3846
What does this implement/fix? Explain your changes.
Add example to
linear_model.PoissonRegressor.