8000 DOC Specify base_estimator=None in CalibratedClassifierCV by alfaro96 · Pull Request #17393 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Specify base_estimator=None in CalibratedClassifierCV #17393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2020
Merged

DOC Specify base_estimator=None in CalibratedClassifierCV #17393

merged 3 commits into from
Jul 16, 2020

Conversation

alfaro96
Copy link
Member

Reference Issues/PRs

Partially addresses #17295.

What does this implement/fix? Explain your changes.

This PR specifies the meaning of base_estimator=None in sklearn.calibration.CalibratedClassifierCV.

thomasjpfan
thomasjpfan reviewed Jun 1, 2020
View reviewed changes
@alfaro96 alfaro96 requested a review from thomasjpfan June 1, 2020 20:24
thomasjpfan
thomasjpfan approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alfaro96 !

NicolasHug
NicolasHug approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member
@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alfaro96 , nit but LGTM anyway

@alfaro96
Copy link
Member Author
alfaro96 commented Jun 1, 2020

Thanks @thomasjpfan @NicolasHug!

@cmarmo
Copy link
Contributor
cmarmo commented Jul 16, 2020

Hello @scikit-learn/core-devs , this one is ready for merging. Thanks!

@NicolasHug NicolasHug changed the title DOC Specify the meaning of base_estimator=None in CalibratedClassifierCV DOC Specify base_estimator=None in CalibratedClassifierCV Jul 16, 2020
@NicolasHug NicolasHug merged commit 04fb00d into scikit-learn:master Jul 16, 2020
@NicolasHug
Copy link
Member

Thanks for the reminder @cmarmo and thanks again @alfaro96

jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 @jayzed82
DOC Specify base_estimator=None in CalibratedClassifierCV (scikit-lea…
349030c 
…rn#17393)
@alfaro96 alfaro96 deleted the specify_base_estimator_calibratedcv branch November 11, 2020 08:45
@ogrisel ogrisel mentioned this pull request Oct 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfaro96 @cmarmo @NicolasHug @thomasjpfan
0