MNT remove boston from the common test / estimator checks #17356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Towards #16155 |
thomasjpfan
reviewed
May 27, 2020
sklearn/utils/estimator_checks.py
Outdated
| X, y = load_boston(return_X_y=True) | ||
| X, y = shuffle(X, y, random_state=0) | ||
| X, y = X[:n_samples], y[:n_samples] | ||
| def _regression_dataset(n_samples=200): |
There was a problem hiding this comment.
Not a blocker. The first call to _regression_dataset will create a dataset with n_samples, and for all proceeding calls n_samples will do nothing.
At this point, I would just define REGRESSION_DATASET on top
REGRESSION_DATASET = make_regression(...)And then have the checks do:
X, y = REGRESSION_DATASETCo-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
|
@adrinjalali , @amueller do you mind to have a look? Thanks! |
But keep the lazy generation code.
ogrisel
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
I went ahead and addressed #17356 (comment) by hardcoding the dataset size (but keeping the lazy dataset generation in a private helper function to avoid having too complex code being executed at module import time.
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17182
Using
make_regressioninstead ofload_bostonin the common test.