8000 MNT Replace kwargs by named args for resample by alfaro96 · Pull Request #17324 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Replace kwargs by named args for resample #17324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

MNT Replace kwargs by named args for resample #17324

merged 1 commit into from
May 25, 2020

Conversation

alfaro96
Copy link
Member
@alfaro96 alfaro96 commented May 24, 2020 •
edited
Loading

Reference Issues/PRs

Partially addresses #15761.

What does this implement/fix? Explain your changes.

Replaces the keyword arguments by named arguments in the sklearn.utils.resample function. This should help with maintenance and make easier to understand the documentation.

thomasjpfan
thomasjpfan approved these changes May 24, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you @alfaro96 !

@alfaro96
Copy link
Member Author

Thanks for the quick review @thomasjpfan!

@jnothman
Copy link
Member

Oh. I'd not seen this and just opened #17345 about it. Hmm I should check if there are other instances

@jnothman jnothman mentioned this pull request May 25, 2020
Closed
@jnothman jnothman merged commit f42cf8a into scikit-learn:master May 25, 2020
@alfaro96 alfaro96 deleted the replace_kwargs_resample branch May 26, 2020 15:29
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@alfaro96 @viclafargue
MNT Replace kwargs by named args for resample (scikit-learn#17324)
5d7401b
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 @jayzed82
MNT Replace kwargs by named args for resample (scikit-learn#17324)
036adf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfaro96 @jnothman @thomasjpfan
0