8000 Fix argument ref in Isomap docs by AdamSpannbauer · Pull Request #17217 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Fix argument ref in Isomap docs #17217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2020
Merged

Fix argument ref in Isomap docs #17217

merged 1 commit into from
May 14, 2020

Conversation

AdamSpannbauer
Copy link
Contributor

Reference Issues/PRs

I didn't find an open issue for this.

What does this implement/fix? Explain your changes.

Isomap documentation on the manifold module documentation incorrectly references the path_method argument:

The eigensolver can be specified by the user with the path_method keyword of Isomap.

This PR simply updates path_method to eigen_solver:

The eigensolver can be specified by the user with the eigen_solver keyword of Isomap.

Any other comments?

Link to Isomap source in case it's relevant.

@hugolmn
Copy link
Contributor
hugolmn commented May 14, 2020 •
edited
Loading

Good job on spotting this mistake! Looks like it was copy-pasted from just above in the documentation

thomasjpfan
thomasjpfan approved these changes May 14, 2020
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you @AdamSpannbauer !

@thomasjpfan thomasjpfan merged commit 8595fe4 into scikit-learn:master May 14, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@AdamSpannbauer @gio8tisu
DOC Fix argument ref in Isomap docs (scikit-learn#17217)
60c5266
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 18, 2020
@AdamSpannbauer @adrinjalali
DOC Fix argument ref in Isomap docs (scikit-learn#17217)
ee9a374
adrinjalali pushed a commit that referenced this pull request May 19, 2020
@AdamSpannbauer @adrinjalali
DOC Fix argument ref in Isomap docs (#17217)
125c111
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@AdamSpannbauer @viclafargue
DOC Fix argument ref in Isomap docs (scikit-learn#17217)
0c09567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@hugolmn hugolmn hugolmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamSpannbauer @hugolmn @thomasjpfan
0