-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG] API kwonly args in impute, inspection, kernel_ridge, and linear_model #16926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All reactions
tests are failing though |
The failures are valid. There are in the codebase that is using position arguments that would raise the |
They are valid. Mostly, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
All green. |
Merging with +3. Thanks! |
…rn#16926) , and linear_model
…rn#16926) , and linear_model
Towards #15005.
In the interest of easier review combining changes in
impute
,inspection
,kernel_ridge
, andlinear_model
in this PR.