8000 [MRG] API kwonly args in impute, inspection, kernel_ridge, and linear_model by adrinjalali · Pull Request #16926 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] API kwonly args in impute, inspection, kernel_ridge, and linear_model #16926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 19, 2020
Merged

[MRG] API kwonly args in impute, inspection, kernel_ridge, and linear_model #16926

merged 10 commits into from
Apr 19, 2020

Conversation

adrinjalali
Copy link
Member

Towards #15005.

In the interest of easier review combining changes in impute, inspection, kernel_ridge, and linear_model in this PR.

@adrinjalali adrinjalali added this to the 0.23 milestone Apr 15, 2020
@adrinjalali adrinjalali changed the title API kwonly args in impute, inspection, kernel_ridge, and linear_model [MRG] API kwonly args in impute, inspection, kernel_ridge, and linear_model Apr 15, 2020
@TomDLT
Copy link
Member
TomDLT commented Apr 16, 2020

tests are failing though

@thomasjpfan
Copy link
Member

The failures are valid. There are in the codebase that is using position arguments that would raise the FutureWarnings.

@thomasjpfan
Copy link
Member
thomasjpfan commented Apr 16, 2020 •
edited
Loading

There are some that are not valid as well.. looking into it.

They are valid. Mostly, orthogonal_mp calls needs to be updated to use keyword arguments.

jnothman
jnothman reviewed Apr 16, 2020
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

@adrinjalali
Copy link
Member Author

All green.

@rth
Copy link
Member
rth commented Apr 19, 2020

Merging with +3. Thanks!

@rth rth merged commit dc0cc6e into scikit-learn:master Apr 19, 2020
@adrinjalali adrinjalali deleted the kwargs/ikl branch April 20, 2020 09:41
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@adrinjalali @gio8tisu
[MRG] API kwonly args in impute, inspection, kernel_ridge (scikit-lea…
ed5794d 
…rn#16926)

, and linear_model
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@adrinjalali @viclafargue
[MRG] API kwonly args in impute, inspection, kernel_ridge (scikit-lea…
eff9e58 
…rn#16926)

, and linear_model
@woctezuma woctezuma mentioned this pull request Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
API module:impute module:inspection module:linear_model
Projects
None yet
Milestone
0.23
Development

Successfully merging this pull request may close these issues.
5 participants
@adrinjalali @TomDLT @thomasjpfan @rth @jnothman
0