8000 TST Fixes estimator checks for classifers when poor_score tag is True by thomasjpfan · Pull Request #16851 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Fixes estimator checks for classifers when poor_score tag is True #16851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 27, 2020
Merged

TST Fixes estimator checks for classifers when poor_score tag is True #16851

merged 8 commits into from
Jun 27, 2020

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Fixes #16799

What does this implement/fix? Explain your changes.

Skips tests on predictions for classifiers when the poor_score tag is set to True.

@thomasjpfan thomasjpfan changed the title ENH Fixes estimator checks for classifers when poor_score tag is True TST Fixes estimator checks for classifers when poor_score tag is True Apr 6, 2020
amueller
amueller approved these changes May 20, 2020
View reviewed changes
Copy link
Member
@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrinjalali
Copy link
Member

linting issue? But I'm not sure why

rth
rth approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 692899d into scikit-learn:master Jun 27, 2020
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
@thomasjpfan @glemaitre
TST Fix estimator checks for classifers with poor_score tag (scikit-l…
3610f37 
…earn#16851)
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@thomasjpfan @jayzed82
TST Fix estimator checks for classifers with poor_score tag (scikit-l…
90d94fb 
…earn#16851)
@not-a-feature not-a-feature mentioned this pull request Mar 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@rth rth rth approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check_classifiers_predictions in check_estimators doesn't support poor_score tag
4 participants
@thomasjpfan @adrinjalali @amueller @rth
0