test cases for feature_extraction.text #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # error with bad analyzer | ||
| vm.analyzer = 'invalid_analyzer' | ||
| assert_raises(ValueError, vm.build_analyzer) |
There was a problem hiding this comment.
I would rather have those tests for the CountVectorizer / HashingVectorizer classes instead as their are less subject to refactoring (public API) while VectorizerMixin is more private API hence more subject to future change.
|
Thanks. I will merge this as soon as you address the previous comment. If you don't have time / will to address it, I can also merge anyway as this is already a net benefit. |
|
Nah, no problem - I should be able to get to it later today. |
|
That should be it. I moved the tests for _check_stop_lists to run from a CountVectorizer as well. |
ogrisel
added a commit
that referenced
this pull request
Feb 7, 2013
test cases for feature_extraction.text
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends test coverage in feature_extraction.text and fixes a few typos in the module's documentation.