8000 DOC Remind to update the version in maintainers guide by jeremiedbb · Pull Request #16589 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Remind to update the version in maintainers guide #16589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeremiedbb
Copy link
Member

@adrinjalali you removed that in #15759. I think it's important to not forget to do that. wdyt ?

Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Not sure why I removed it.

@adrinjalali adrinjalali merged commit 5009d11 into scikit-learn:master Feb 28, 2020
@NicolasHug
Copy link
Member

That was probably me. I must have removed it from that section because it's still present in the section below "Making a release".

These sections had some redundant info.

@jeremiedbb
Copy link
Member Author
jeremiedbb commented Feb 28, 2020

So you think we should not say that in the Preparing a release PR section ?

@NicolasHug
Copy link
Member

It's fine, it's just redundant. The frontier between "preparing a release PR" and "making a release" isn't clear anyway.

@adrinjalali
Copy link
Member

I think if you went through the doc and found it useful to be there while making a release, then it belongs there.

panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@jeremiedbb jeremiedbb deleted the update-maintainers-guide branch July 20, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0