8000 added versionadded 0.21 and versionchanged 0.21 where applicable, aft… by alhewpl · Pull Request #16214 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

added versionadded 0.21 and versionchanged 0.21 where applicable, aft… #16214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alhewpl
Copy link
@alhewpl alhewpl commented Jan 25, 2020

…er inspecting changelog

Reference Issue #15426
Partially adding version added/changed to fixes/features implemented in this version (0.21)

@Schindst
@wimlds
@adrinjalali

@@ -6,6 +6,7 @@
*.lprof
*.swp
*.swo
env/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change

@@ -755,6 +755,8 @@ class AgglomerativeClustering(ClusterMixin, BaseEstimator):
n_connected_components_ : int
The estimated number of connected components in the graph.

.. versionchanged:: 0.21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionchanged really needs some description of how the behaviour has changed. And I think it should be used only rarely, when it would really help the user to understand a substantial change across versions.

@noatamir
Copy link
Contributor

@alhewpl can you continue to work on this?

@cmarmo
Copy link
Contributor
cmarmo commented May 11, 2020

Thanks @alhewpl for your work. Version 0.21 has been finalized in #16737. Closing this one.

@cmarmo cmarmo closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0