Quick fix for class deprecation decorator #15995
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
reviewed
Dec 31, 2019
NicolasHug
reviewed
Jan 31, 2020
| cls.__init__ = wrapped | ||
| cls.__new__ = wrapped_new |
There was a problem hiding this comment.
would it be enough to only decorate new and not init now?
|
@NicolasHug - this has fallen through the cracks. I'll try to come back and wrap it up over the weekend. |
|
Did you still want to work on this? |
|
yes, can come back to it after the sprint/once the current PR is opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty fix for my use case, but looking at the astropy decorator I suspect there may be some corner cases that still doesn't work.
Reference Issues/PRs
closes #15994