[MRG] Fix whats new link #15634
Merged
[MRG] Fix whats new link #15634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't say this is a blocker really. I'm not sure what the link is supposed to be also. I noticed that it links to the list of whats new entries, but I thought that's by design. If we change that, where do people find the list of the changelogs for different releases? |
The button is "what's new in 0.22"
Like before, at the bottom in the "what's new (changelog)" link
Indeed not a blocker but a no brainer IMHO |
thomasjpfan
approved these changes
Nov 15, 2019
|
It use to link to the whats new (with the items) and not a whats_new TOC. With #15288 the link now points to an index page. |
adrinjalali
approved these changes
Nov 15, 2019
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 18, 2019
* fix whats new link * oops fixed bracket
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 18, 2019
* fix whats new link * oops fixed bracket
adrinjalali
pushed a commit
that referenced
this pull request
Nov 19, 2019
* fix whats new link * oops fixed bracket
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
* fix whats new link * oops fixed bracket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current "What's new in 0.22" button in the index page links to the list of what's news instead of the 0.22's whatsnew
Also fix spelling
@thomasjpfan @adrinjalali @glemaitre