DOC Fix issues in what's new. #15564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Nov 7, 2019
doc/whats_new/v0.22.rst
Outdated
| corresponding scorers 'roc_auc_ovr', 'roc_auc_ovo', 'roc_auc_ovr_weighted', | ||
| and 'roc_auc_ovo_weighted'. :pr:`12789` and :pr:`15274` by | ||
| corresponding scorers `roc_auc_ovr`, `roc_auc_ovo`, `roc_auc_ovr_weighted`, | ||
| and `roc_auc_ovo_weighted`. :pr:`12789` and :pr:`15274` by |
There was a problem hiding this comment.
in fact they should string so it should for instance 'roc_auc_ovo_weighted'. Otherwise LGTM
There was a problem hiding this comment.
Grrrr I have reintroduced the warnings... :(
There was a problem hiding this comment.
Ah no, wait! those are the warnings I have fixed in #15560! :)
thomasjpfan
approved these changes
Nov 7, 2019
|
Thank you @cmarmo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR fixes some link and API description issues in
v0.22.rst