8000 [MRG] Release highlights order by NicolasHug · Pull Request #15552 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Release highlights order #15552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2019
Merged

[MRG] Release highlights order #15552

merged 4 commits into from
Nov 7, 2019

Conversation

NicolasHug
Copy link
Member

I updated the order of the highlights which is now

  • plotting api
  • stacking classifier and regressor
  • permutation-based importance
  • missing values support in GBDT (should add SW if sample_weight support in HistGradientBoostingClassifier #14830 gets merged)
  • precomputed neighboros graph
  • knn imputation
  • tree pruning
  • retrieve openml dataframes
  • checking sklearn compatibility
  • multiclass support for roc auc

No strong opinion. I'd remove the last one to keep to list shorter.

Also mentioned the website revamping in the what's new. IMHO this is the most impactful change, by far.

@jnothman @amueller @thomasjpfan @adrinjalali

@NicolasHug NicolasHug mentioned this pull request Nov 6, 2019
Closed
13 tasks
@amueller
Copy link
Member
amueller commented Nov 6, 2019

unsurprisingly I'd like to keep the last one, but I don't have a strong opinion.
Also: omg this is amazing! this will be such a great release. Great job everybody!

@jnothman
Copy link
Member
jnothman commented Nov 6, 2019

Circle isn't happy

But I'm fine with this order

adrinjalali
adrinjalali approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the order, and I think the last item is pretty useful, kinda towards a more "developer friendly" documentation etc.

@jnothman jnothman merged commit faaeba4 into scikit-learn:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasHug @amueller @jnothman @adrinjalali
0