BUG: do not filter searchindex for pdf doc generation #15433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
reviewed
Nov 1, 2019
| if not os.path.exists(searchindex_path): | ||
| return | ||
|
|
||
| print('Removing methods from search index') |
There was a problem hiding this comment.
Is that a temporary debugging print statement you meant to remove?
There was a problem hiding this comment.
OK ignore me, I am seeing that it was moved from above.
lesteve
reviewed
Nov 1, 2019
doc/conf.py
Outdated
| searchindex_path = os.path.join(app.builder.outdir, 'searchindex.js') | ||
|
|
||
| if not os.path.exists(searchindex_path): |
There was a problem hiding this comment.
Not a sphinx expert, but maybe you could use app.builder to only run filter_search_index where the builder is the HTML one?
Alternatively, there may be a sphinx-specific to register hooks (or event or whatever the sphinx actual terms is) only for some builders.
|
That looks good to me, let's merge this one to make master green again (hopefully)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug on master where
filter_search_indextries to run whensearchindex.jsdoes not exist.searchindex.jsdoes not exist when we are building a pdf.CC @lesteve @jnothman @rth