[MRG] Reduce hard-coding in "Gaussian Mixture Model Selection" example #15401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riance types and a wider range or components
|
Hi @yunesj, I know it has been a while... sorry for that. If you are still interested in working on that do you mind fixing conflicts? Thanks! |
|
I am closing this PR as some modifications have already been applied in #17418. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The example plotted the best model, but the code only worked if the best model found had a full covariance matrix. Some other parts, like the title for the plot of the best model, were also hard-coded. This change reduces the amount of fixed code to work in more cases.