[MRG] Add missing entries to whatsnew #15398
Conversation
|
I'll make another PR to clean the whatsnew, I feel like if I do it here there will always be merge conflicts @thomasjpfan @glemaitre @adrinjalali @jnothman for a quick review? |
|
@adrinjalali just added some details about the deprecations and the FutureWarning thing |
doc/whats_new/v0.22.rst
Outdated
| Whether a tool is private or public depends on whether you can import it | ||
| without a leading underscore in the import path. For example | ||
| ``sklearn.pipeline.make_pipeline`` is public, while | ||
| `sklearn.pipeline._name_estimators` is private. | ||
| ``sklearn.ensemble._gb.BaseEnsemble`` is private too because the whole `_gb` | ||
| module is private. |
There was a problem hiding this comment.
It'd be nice to also mention the classes/functions which are private because their name has a leading underscore, eventhough the path may be public.
There was a problem hiding this comment.
There is sklearn.pipeline._name_estimators, were you thinking of something else?
There was a problem hiding this comment.
some _BaseBlahBlah I guess. I think most of them are gonna be in the _filename locations and don't matter anyway. But not for the ones in the root directory.
There was a problem hiding this comment.
sorry I'm not sure I follow. Why doesn't sklearn.pipeline._name_estimators qualify as "classes/functions which are private because their name has a leading underscore eventhough the path may be public"?
| deprecations, `as recommended by the Python documentation | ||
| <https://docs.python.org/3/library/exceptions.html#FutureWarning>`_. | ||
| ``FutureWarnings`` are always shown by default by Python, so the custom | ||
| filter has been removed and scikit-learn no longer hinders with user |
There was a problem hiding this comment.
scikit-learn/sklearn/__init__.py
Line 23 in 32f04d4
There was a problem hiding this comment.
This section is about warnings. I haven't looked into the logger issue but feel free to edit to your liking!
|
Nice work |
|
Thanks for the reviews, merging |
Addresses #15384