8000 [MRG] Deprecate all of utils.testing except all_estimators by NicolasHug · Pull Request #15367 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Deprecate all of utils.testing except all_estimators #15367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 28, 2019
Merged

[MRG] Deprecate all of utils.testing except all_estimators #15367

merged 15 commits into from
Oct 28, 2019

Conversation

NicolasHug
Copy link
Member

Put all_estimators in utils now.

Should finish the utils deprecations of #6616 (comment)

@thomasjpfan @adrinjalali @glemaitre ;)

@thomasjpfan
Copy link
Member

We should update classes.rst and utilities.rst to point to the new path.

adrinjalali
adrinjalali reviewed Oct 28, 2019
View reviewed changes
@qinhanmin2014 qinhanmin2014 mentioned this pull request Oct 28, 2019
Closed
adrinjalali
adrinjalali reviewed Oct 28, 2019
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just noticed we may be importing all_estimators now from _testing. We should only import it from utils.

@NicolasHug
Copy link
Member Author

We should only import it from utils.

yes, CI should be catching these

@adrinjalali adrinjalali self-assigned this Oct 28, 2019
adrinjalali
adrinjalali approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasHug
Copy link
Member Author

It's green \o/

Let's get it in before any more conflicts araise please @glemaitre @thomasjpfan ^^

@glemaitre glemaitre merged commit b92455a into scikit-learn:master Oct 28, 2019
@glemaitre
Copy link
Member

Thanks @NicolasHug

@denver1117 denver1117 mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees

@adrinjalali adrinjalali

Labels
Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NicolasHug @thomasjpfan @glemaitre @adrinjalali @qinhanmin2014
0