DOC Fix broken link to docs #15364
Merged
DOC Fix broken link to docs #15364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnothman @rth @NicolasHug Adds a documentation page that just redirects. https://79890-843222-gh.circle-artifacts.com/0/doc/documentation.html redirects to |
NicolasHug
approved these changes
Oct 25, 2019
doc/templates/documentation.html
Outdated
| <meta http-equiv="Refresh" content="0; url={{ pathto('index') }}" /> | ||
| </head> | ||
| <body> | ||
| <p>Please follow <a href="{{ pathto('index') }}">this link</a>.</p> |
There was a problem hiding this comment.
Maybe something like
"You will be automatically redirected to the main page"
doc/conf.py
Outdated
| @@ -171,7 +171,8 @@ | |||
|
|
|||
| # Additional templates that should be rendered to pages, maps page names to | |||
| # template names. | |||
| html_additional_pages = {'index': 'index.html'} | |||
| html_additional_pages = {'index': 'index.html', | |||
| 'documentation': 'documentation.html'} | |||
There was a problem hiding this comment.
Suggested change
| 'documentation': 'documentation.html'} | |
| 'documentation': 'documentation.html'} # redirects to index``` |
jnothman
reviewed
Oct 26, 2019
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta http-equiv="Refresh" content="0; url={{ pathto('index') }}" /> |
There was a problem hiding this comment.
Should probably also use a <link rel=canonical to tell search engines this is permanent
jnothman
approved these changes
Oct 27, 2019
rth
approved these changes
Oct 27, 2019
|
|
|
|
Can confirm it works now @oke-aditya . Maybe the build wasn't updated yet when you tried |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #15362
What does this implement/fix? Explain your changes.
Adds documentation as a redirect to index