Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BLD] CircleCI failed when a PR generates sphinx warnings #15355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLD] CircleCI failed when a PR generates sphinx warnings #15355
Changes from all commits
a642e32
5ed1c9c
96cf750
c19c4e3
4d07039
0196e9e
0a0cf5f
c6735d9
455f500
6ac8be2
5c0bafc
7e664e0
a2f3255
0749882
bc08415
f91903e
d533bcb
2fef5e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about:
And leave the rest unchanged. My goal is to reduce the number of
if
statements after this point.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then if
$changed_examples
is empty your regular expression forEXAMPLES_PATTERN
will begin with|
: this generates an error in every checker of regexp I've tested (maybe you know why?) and always crashes my checks in cmarmo#5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Is our Makefile tolerant to extra
|
when eitherchanged_examples
orexamples_in_rst
are empty?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this verbose way work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I go for it.
Next time you write the code and I'll do the review? I feel like the entire process will be way more efficient... ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can do this without introducing the
check
variable:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried: but I was using grep in order to do this and grep throws an exit 1 when it could find anything, so the script exited due to the
set -e
... I can dig deeper if it's reeeally necessary...